nandorojo / burnt

Crunchy toasts for React Native. 🍞
MIT License
1.16k stars 36 forks source link

Not show all text in IOS #39

Open thienvu23 opened 7 months ago

thienvu23 commented 7 months ago

image

Arjan-Zuidema commented 6 months ago

On an iPad it's even worse. Schermafbeelding 2024-03-08 om 12 33 26

The toast could be a lot wider or even higher. And it should never break words as it shows important messages.

kurucaner commented 5 months ago

I'm having the same issue. Any update on this?

kurucaner commented 5 months ago

@nandorojo Is this something you can help us figure out?

nandorojo commented 5 months ago

Hey just a kind reminder not to ping for open source.

The issue lies in the upstream native library we use. If they allowed longer text then we could too.

Keep in mind toast messages must be very short by design, as it's fleeting UI.

kurucaner commented 5 months ago

Thanks for the response nandorojo. I didn't mean to disturb.

Arjan-Zuidema commented 5 months ago

Hey just a kind reminder not to ping for open source.

Imo when you create a package you should respond to issues.

The issue lies in the upstream native library we use. If they allowed longer text than we could do.

If only you just reacted with this, it would be fine.

Keep in mind toast messages must be very short by design, as it's fleeting UI.

This is very opinionated, imo it should also be possible to add the whole lorum ipsum

nandorojo commented 5 months ago

Imo when you create a package you should respond to issues.

While it’s fine for that to be your opinion, giving away my code for free doesn’t necessitate also giving away my time for free.

I maintain a lot of packages and have a better response rate than most developers. It’s a lot of work, and it’s meant to be collaborative. That’s why you can read the code and send PRs.

As a common practice, if you want more help with an open source issue, you can sponsor or offer to pay to prioritize an issue. Otherwise, you should just expect regular response times.

And FWIW, maintainers are always more likely to help someone who is courteous. And even more someone who contributes to libraries / releases their own libraries.

If only you just reacted with this, it would be fine.

And that’s what I did.

If you want the info in less than a few days, all you have to do is open the code. It’s fine to ask questions and not want to spend time doing that if you’re willing to wait. But keep in mind that that’s always possible.

This is very opinionated, imo it should also be possible to add the whole lorum ipsum

It is indeed. But it’s inline with how Apple’s toasts work too.

I have nothing against showing more text if the upstream library would allow it. But I’m just guessing that this is why they did it that way.

It probably makes sense to open an upstream issue and link it here.

nandorojo commented 5 months ago

Thanks for the response nandorojo. I didn't mean to disturb.

@kurucaner no worries, just trying to keep my GitHub notifications from exploding is all. Thanks for the PR, will take a look.

kurucaner commented 5 months ago

Thanks for the response nandorojo. I didn't mean to disturb.

@kurucaner no worries, just trying to keep my GitHub notifications from exploding is all. Thanks for the PR, will take a look.

I'm loving all the packages you are sharing. Moti, zeego, and burnt are really very useful projects. Thank you so much for your time. I'm hoping to contribute more in the future.

nandorojo commented 5 months ago

Glad they’re useful!

By the way I get the frustration when you urgently want a fix from open source and you’re stuck waiting. This is how I usually try to handle it:

https://github.com/Shopify/flash-list/pull/824#issuecomment-1725378008

kurucaner commented 5 months ago

Glad they’re useful!

By the way I get the frustration when you urgently want a fix from open source and you’re stuck waiting. This is how I usually try to handle it:

Shopify/flash-list#824 (comment)

It's a very fair way of handling requests from open source projects. Thanks for the tip!

nandorojo commented 5 months ago

Related issue: https://github.com/ivanvorobei/SPIndicator/issues/29

ivanvorobei commented 5 months ago

On an iPad it's even worse. Schermafbeelding 2024-03-08 om 12 33 26

The toast could be a lot wider or even higher. And it should never break words as it shows important messages.

You using wrong way to show important message

ivanvorobei commented 5 months ago

Hey just a kind reminder not to ping for open source.

Imo when you create a package you should respond to issues.

The issue lies in the upstream native library we use. If they allowed longer text than we could do.

If only you just reacted with this, it would be fine.

Keep in mind toast messages must be very short by design, as it's fleeting UI.

This is very opinionated, imo it should also be possible to add the whole lorum ipsum

I hope you skip my open source and stuff that I did. Looks like instead of "thanks you" you think I owe you something. Not great at all

Arjan-Zuidema commented 5 months ago

First of all:

Hey just a kind reminder not to ping for open source.

Sounds kinda harsh, so that's the reason for my kinda harsh response.

Imo when you create a package you should respond to issues.

While it’s fine for that to be your opinion, giving away my code for free doesn’t necessitate also giving away my time for free.

I maintain a lot of packages and have a better response rate than most developers. It’s a lot of work, and it’s meant to be collaborative. That’s why you can read the code and send PRs.

As a common practice, if you want more help with an open source issue, you can sponsor or offer to pay to prioritize an issue. Otherwise, you should just expect regular response times.

And FWIW, maintainers are always more likely to help someone who is courteous. And even more someone who contributes to libraries / releases their own libraries.

I know it's a lot of time to maintain a package and I surely appreciate that as I also maintain packages (also for free in my free time). But not responding to issues for over a month looks bad. But that's just my opinion.

If only you just reacted with this, it would be fine.

And that’s what I did.

If you want the info in less than a few days, all you have to do is open the code. It’s fine to ask questions and not want to spend time doing that if you’re willing to wait. But keep in mind that that’s always possible.

I don't expect it to be fixed in a few days, but it seems like little effort to reply like you just did within a few days instead of after a month. People depend on packages, and it can be frustrating when maintainers don't respond. Also an answer that does not meet the response that people hope for is better than no response.