search

nandorojo / dripsy

🍷 Responsive, unstyled UI primitives for React Native + Web.
https://dripsy.xyz
MIT License
2.01k stars 80 forks source link

Support paddingHorizontal/vertical and marginHorizontal/vertical #189

Closed hirbod closed 2 years ago

hirbod commented 2 years ago

Hi @nandorojo,

while I know sx has "px, py, mx, my", I still think that TypeScript should not complain when using the react-native names, unless you have a real reason why which I am not aware of.

Because using them works just fine, just the Types are missing (in this case are aliased). I do like the abbreviation, but sometimes I am "porting" stuff and this forces me to refactor.

What do you think?

nandorojo commented 2 years ago

Yeah fair point, I just have to see if it's easy to add

nandorojo commented 2 years ago

Fixed in 3.6.1

nandorojo commented 2 years ago

Actually there may be a regression here, if it's too complex to fix in a short amount of time I may have to revert for now.

hirbod commented 2 years ago

It is not a big deal, no worries. If it cause more pain then just ignore it.

nandorojo commented 2 years ago

Pretty sure I fixed it all now, yarn add dripsy@canary for 3.6.2 should have it.