search

nandorojo / expo-next-react-navigation

⛴ Make Next.js and react-navigation play nicely together with an Expo/React Native Web app.
406 stars 32 forks source link

Updated next #65

Closed cmaycumber closed 3 years ago

cmaycumber commented 3 years ago

Fixes shallow routing by upgrading next to v10

nandorojo commented 3 years ago

Should we upgrade RN while we're at it?

This would require a PR to expo-navigation-core (should have been a monorepo 😬)

cmaycumber commented 3 years ago

Should we upgrade RN while we're at it?

This would require a PR to expo-navigation-core (should have been a monorepo 😬)

The react native is old, I'm on expo 41, I assume you probably are too. I can help with this too if it's something you think we should do.

cmaycumber commented 3 years ago

expo-navigation-core

Can we monorepo it?

nandorojo commented 3 years ago

Oh sorry I meant React navigation. I'm not sure if the RN dev dependency makes a difference, I don't think it does.

cmaycumber commented 3 years ago

That's a good point. It probably won't have an impact

nandorojo commented 3 years ago

I really would like to get types working for React navigation with useRouting but I never spent much time on it

cmaycumber commented 3 years ago

I really would like to get types working for React navigation with useRouting but I never spent much time on it

Do you think it's possible? I'll see if I can take a jab at it sometime this week.

nandorojo commented 3 years ago

Yeah I think so. I started it before. I think it just needs some tweaks.

For instance, if we pass the navigation prop type as the first generic, we might need to then extract its arguments and pass them to navigate

I did something similar for the next web stack I'm slowly working on