search

nandorojo / moti

🐼 The React Native (+ Web) animation library, powered by Reanimated 3.
https://moti.fyi
MIT License
3.9k stars 120 forks source link

Skeleton covers children when show={false} on web #271

Closed adamhari closed 1 year ago

adamhari commented 1 year ago

Is there an existing issue for this?

Current Behavior

Skeleton is rendering overtop of it's children, regardless of the value of the show prop.

Expected Behavior

Skeleton is not visible and it's children are visible when show is false.

Steps To Reproduce

  1. Add a Skeleton component with show=false.
  2. Add children to the Skeleton

Versions

- Moti: 0.24
- Reanimated: 3.0.0
- React Native Web: 0.18.12

Screenshots

Moti 0.23.7

image

Moti 0.24.0

image

Reproduction

https://stackblitz.com/edit/nextjs-dhaw4c?file=pages%2Findex.tsx,package.json

nandorojo commented 1 year ago

Looks like a regression, I’ll look into this tomorrow

nandorojo commented 1 year ago

does passing backgroundColor=“transparent” fix it?

adamhari commented 1 year ago

does passing backgroundColor=“transparent” fix it?

Yeah, that seems to fix the issue.

nandorojo commented 1 year ago

Fixed in 0.24.1