search

nandorojo / react-native-heroicons

Hero Icons for React Native. 🫡
64 stars 6 forks source link

Add 16×16 micro icons #6

Closed brennanangel closed 6 months ago

brennanangel commented 6 months ago

@nandorojo I realized I still needed to adjust the code to add the new "micro" icons (16px). Sorry for the mistakes and fast follow!

I had to work around src being in .gitignore to update the icons but I think this looks right.

nandorojo commented 6 months ago

I'm a bit confused. Can you clarify your changes? src should be untouched and created from the generate script.

nandorojo commented 6 months ago

Are the mini ones 14px or 16px?

brennanangel commented 6 months ago

I'm a bit confused. Can you clarify your changes? src should be untouched and created from the generate script.

That's what I thought too. Noticed that my last PR somehow updated the src folder when running yarn prepare despite being in .gitignore

Anyways, please check out the recent changes in this PR that add the 16×16 micro icons (there aren't any 14px icons in Heroicons) :)

brennanangel commented 6 months ago

Are the mini ones 14px or 16px?

That was a typo on my part. This adds the 16px "micro" ones that were just added in Heroicons v2.1.0: https://github.com/tailwindlabs/heroicons/releases/tag/v2.1.0

nandorojo commented 6 months ago

Got it, and is the source code there from the previous PR? for the icons themselves

brennanangel commented 6 months ago

Got it, and is the source code there from the previous PR? for the icons themselves

Yes, the icons were added in the previous PR image

Unfortunately, this will likely require a new release so users can have access to the "micro" icons