search

nandorojo / solito

🧍‍♂️ React Native + Next.js, unified.
https://solito.dev
MIT License
3.54k stars 181 forks source link

Warning after upgrading to Expo 46 / Next.js 12.2 #143

Closed neilgamb closed 2 years ago

neilgamb commented 2 years ago

Thanks for all the effort on the recent PR to upgrade Solito. I followed the diffs in https://github.com/nandorojo/solito/pull/137 and was able to upgrade our repo successfully. The only thing I am seeing is the warning:

WARN Constants.platform.ios.model has been deprecated in favor of expo-device's Device.modelName property. This API will be removed in SDK 45

I am not super worried about this, but also saw that there was some discussion about this warning during the upgrade process. But didn't see anything specifically to fix it. Our app is running fine but was wondering if people we're still seeing this and / or have been able to fix it?

In my yarn.lock:

expo-asset@~8.6.1:
  version "8.6.1"
  resolved "https://registry.yarnpkg.com/expo-asset/-/expo-asset-8.6.1.tgz#86355b3e231e8aa6cf68a456ce9746dff1478b48"
  integrity sha512-urbUp1YtwH2J0Qc3inGQJdqTjWKML77SeMNgff+iR9MUE8gDkFqSCDjrBi7i5Oj5DDtq43mmtDg8G8ei6Vchcg==
  dependencies:
    blueimp-md5 "^2.10.0"
    expo-constants "~13.2.2"
    expo-file-system "~14.1.0"
    invariant "^2.2.4"
    md5-file "^3.2.3"
    path-browserify "^1.0.0"
    url-parse "^1.5.9"

expo-constants@~13.1.0:
  version "13.1.1"
  resolved "https://registry.yarnpkg.com/expo-constants/-/expo-constants-13.1.1.tgz#78c26c760cc63cd5608bc4b51bd159d7339d8054"
  integrity sha512-QRVHrrMCLenBzWZ8M+EvCXM+jjdQzFMW27YQHRac3SGGoND1hWr81scOmGwlFo2wLZrYXm8HcYt1E6ry3IIwrA==
  dependencies:
    "@expo/config" "^6.0.14"
    uuid "^3.3.2"

expo-constants@~13.2.2, expo-constants@~13.2.4:
  version "13.2.4"
  resolved "https://registry.yarnpkg.com/expo-constants/-/expo-constants-13.2.4.tgz#eab4a553f074b2c60ad7a158d3b82e3484a94606"
  integrity sha512-Zobau8EuTk2GgafwkfGnWM6CmSLB7X8qnQXVuXe0nd3v92hfQUmRWGhJwH88uxXj3LrfqctM6PaJ8taG1vxfBw==
  dependencies:
    "@expo/config" "~7.0.0"
    uuid "^3.3.2"
poe-react-apps on  upgrade/solito-expo-next-deps ❯ yarn why expo-asset
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "expo-asset"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "expo-asset@8.6.1"
info Reasons this module exists
   - "_project_#expo-app#expo" depends on it
   - Hoisted from "_project_#expo-app#expo#expo-asset"
info Disk size without dependencies: "444KB"
info Disk size with unique dependencies: "2.81MB"
info Disk size with transitive dependencies: "13.16MB"
info Number of shared dependencies: 64
✨  Done in 0.40s.

Thanks!

nandorojo commented 2 years ago

Looks like this should help: https://github.com/expo/expo/issues/15110

neilgamb commented 2 years ago

I actually saw that and tried several of those resolutions but had missed one of them that ended up fixing it. Thank you!

I manually removed all expo-constant deps references from my yarn.lock and re-ran yarn and all good 👌🏻