nandorojo / solito

🧍‍♂️ React Native + Next.js, unified.
https://solito.dev
MIT License
3.54k stars 180 forks source link

⚡️ Instantly clone & deploy is not happy #22

Closed flexbox closed 2 years ago

flexbox commented 2 years ago

As a developer I can clone and deploy on vercel So that I can try if it's working

image

When we hit the deploy button...

Deploy with Vercel

...it's impossible to

  • Select the folder apps/next as the root of your Next.js app on the Vercel setup.

I have a feeling we can add some params to fix it, but I don't know which one 😅

https://github.com/nandorojo/solito/blob/e2f41ee89f2dc46dbdaa2d9fe74e9678dec66da6/example-monorepos/blank/readme.md?plain=1#L11

nandorojo commented 2 years ago

ah! this must be due to #15. the param is root-directory, which should point to apps/next

nandorojo commented 2 years ago

The button you linked to worked fine for me. I assume the broken one is at solito.dev/starter?

flexbox commented 2 years ago

I tried from https://github.com/nandorojo/solito/tree/master/example-monorepos/blank

nandorojo commented 2 years ago

I see, you’re right. Is root-directory defined there? I’m on my phone so it’s hard for me to check

nandorojo commented 2 years ago

fixed from my phone lol: https://github.com/nandorojo/solito/commit/eed3f3e9bf58138eb5072cee1eaa98355c9f5204

flexbox commented 2 years ago

🤔

thanks for the input, I tried with image

&root-directory=apps/next

and not

&root-directory=/apps/next

image

Vercel seams happy

nandorojo commented 2 years ago

thanks for the heads up! any chance you’d copy this the updated button to the solito “starter” page in the docs through a PR?

flexbox commented 2 years ago

@nandorojo 😂 you are a legend

I will have a look!

flexbox commented 2 years ago

thanks for the heads up! any chance you’d copy this the updated button to the solito “starter” page in the docs through a PR?

It was the good param, I tried from solito.dev/starter

image

All good now!