nandorojo / solito

🧍‍♂️ React Native + Next.js, unified.
https://solito.dev
MIT License
3.54k stars 180 forks source link

fix: removed metro-minify-esbuild from expo project #33

Closed gabrielEloy closed 2 years ago

gabrielEloy commented 2 years ago

as discussed in Solito Issue #32 metro-minify-esbuild causes android builds (didn't test on IOS) to result in a blank screen app

https://user-images.githubusercontent.com/37480915/160510233-defaee67-c770-41d8-a487-795797162691.mp4

removing this dependency fixed the problem for me

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

solito-app – ./example-monorepos/blank/apps/next

🔍 Inspect: https://vercel.com/fernandorojo/solito-app/FnAmVtjY37TSz5PtouEQ2ychJuWc
✅ Preview: https://solito-app-git-fork-gabrieleloy-fix-create-ff62ee-fernandorojo.vercel.app

solito – ./docs

🔍 Inspect: https://vercel.com/fernandorojo/solito/EK56JjN3ryYdGRocgQ1S1MVVhwWo
✅ Preview: Canceled

nandorojo commented 2 years ago

Odd, maybe this requires opening an issue in metro-minify-esbuild. I'll open an issue there for reference.

nandorojo commented 2 years ago

merged, thanks!