nandorojo / solito

🧍‍♂️ React Native + Next.js, unified.
https://solito.dev
MIT License
3.54k stars 180 forks source link

Fix docs sidebar not opening in mobile #432

Closed arielvieira closed 1 year ago

arielvieira commented 1 year ago

Fix CSS bug that prevents the mobile sidebar from opening when parent of a position: fixed element has a filter property.

before the change ![image](https://github.com/nandorojo/solito/assets/17505779/0d6d4af4-cc29-41b2-b294-0e23df171e97)
after the fix ![image](https://github.com/nandorojo/solito/assets/17505779/ec5b404d-0f68-43a7-87c8-000a27bd3422)

fixes: #430

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 10:38pm
solito-app ❌ Failed (Inspect) Sep 29, 2023 10:38pm
vercel[bot] commented 1 year ago

@arielvieira is attempting to deploy a commit to the Beatgig Team on Vercel.

A member of the Team first needs to authorize it.

nandorojo commented 1 year ago

thanks! would be great to update zeego too. why the lock file changes btw?

arielvieira commented 1 year ago

When I cloned the repo and installed the dependencies locally it was updated.

That's because when the docs/package.json was updated with the new next.js version the docs/yarn.lock wasn't, due to not running yarn in docs folder.

nandorojo commented 1 year ago

Got it, thanks!