iOS Simulator: Unable to resolve module expo-image from .../node_modules/solito/build/image/expo/image.js

sejori commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Do you want this issue prioritized?

[ ] Yes, I have sponsored
[X] Not urgent

Current Behavior

App compiles and renders correctly when targeting web with next but title error is shown on simulator with expo. Can successfully create development builds on AES and launch but nothing rendered before error.

Expected Behavior

Native app would render shared app packages same as on web.

Steps To Reproduce

Create expo-router starter template
Implement listed packages: "@react-native-async-storage/async-storage": "^1.19.2", "@react-native-picker/picker": "^2.5.0", "@tamagui/checkbox": "^1.72.1", "@tamagui/config": "^1.72.1", "@tamagui/lucide-icons": "^1.72.1", "expo-document-picker": "^11.7.0", "expo-image-picker": "^14.3.2", "expo-linear-gradient": "^12.3.0", "expo-navigation-bar": "^2.3.0", "expo-web-browser": "^12.3.2", "hex-color-regex": "^1.1.0", "hex-opacity": "^1.0.16", "next-fonts": "^1.5.1", "react-hover-image": "^2.0.1", "react-native-iphone-x-helper": "^1.3.1", "react-native-keyboard-aware-scroll-view": "^0.9.5", "react-native-paper": "^5.10.4", "react-native-sectioned-multi-select": "^0.10.0", "react-native-svg": "^13.12.0", "react-native-vector-icons": "^10.0.0", "react-native-web-swiper": "^2.2.4", "react-native-webview": "^13.3.1", "react-responsive": "^9.0.2", "tamagui": "^1.72.1"
Build app on AES
Try to run app on simulator

(Note: I have tried the react-fast-image implementation and the default expo-image, same result)

Versions

- Solito: 4.0.1 (originally 3.0.0)
- Next.js: 13.2.0
- Expo: ~48.0.18
- React Native: 0.71.8

Screenshots

error screenshot

react-fast-image attempt

Reproduction

App bundle download - can give access to source on request

nandorojo commented 1 year ago

you’ll need to install a new dev client for expo-image to work i assume. sounds like it’s not installed properly.

sejori commented 1 year ago

install a new dev-client, you mean make a new dev build on EAS and run that in simulator?

I think I have tried that for both react-fast-image and default expo-image but can try again.

sejori commented 1 year ago

@nandorojo so weirdly there was no expo-image installed. Maybe I had accidentally uninstalled. After reinstalling into apps/expo/package.json the error is gone. We are now facing another issue, please tell me if you would prefer to close this issue and open another one.

The new error is:

nandorojo commented 1 year ago

same issue but with expo-image-picker

sejori commented 1 year ago

Ahah you're right! So basically the idea is that all packages required by expo app must be present in the apps/expo/package.json and the root package.json?

nandorojo commented 1 year ago

native deps go in the expo folder

sejori commented 1 year ago

Brill - thanks for that and great work on the stack 👏

nandorojo / solito