search

nandorojo / solito

🧍‍♂️ React Native + Next.js, unified.
https://solito.dev
MIT License
3.54k stars 180 forks source link

Request: Update to NativeWind V4 #448

Open angel-luis opened 1 year ago

angel-luis commented 1 year ago

Since NativeWind V4 has been released, it would be nice to get an update of the monorepo with-tailwind with the last version! Thank you in advance.

mikevocalz commented 1 year ago

Since NativeWind V4 has been released, it would be nice to get an update of the monorepo with-tailwind with the last version! Thank you in advance.

Try this @angel-luis : https://github.com/mikevocalz/solito-nativewind-v4

nandorojo commented 1 year ago

PR is welcome

rpweb commented 1 year ago

Since NativeWind V4 has been released, it would be nice to get an update of the monorepo with-tailwind with the last version! Thank you in advance.

Try this @angel-luis : https://github.com/mikevocalz/solito-nativewind-v4

@mikevocalz That's cool! screenshot Any clue how I can solve this? It also appears during build. I checked https://www.nativewind.dev/v4/getting-started/typescript but it's already included in your branch.

nandorojo commented 1 year ago

I think that would indicate you’re missing some sort of declaration file. You may need to mention it in your tsconfig’s includes array.

rpweb commented 1 year ago

app-env.d.ts is already included in https://github.com/mikevocalz/solito-nativewind-v4/blob/main/apps/next/tsconfig.json#L19 which containes nativewind/types. Not sure what I am missing.

xinha-sh commented 1 year ago

@rpweb @angel-luis https://github.com/marklawlor/nativewind/issues/600#issuecomment-1804741121 The v4 is an accidental npm release. I guess lots of bugs being encountered. So tread well.

rpweb commented 1 year ago

upgrade to "nativewind": "4.0.16", solved it for me in pages router, but not in app router. https://github.com/marklawlor/nativewind/issues/673

xinha-sh commented 12 months ago

@rpweb I've been testing the nativewind v4 with solito. There are many random things happening. Raised few bugs. The v4 is currently far from stable in my view.

rpweb commented 11 months ago

@rpweb I've been testing the nativewind v4 with solito. There are many random things happening. Raised few bugs. The v4 is currently far from stable in my view.

@xinha-sh With app router? Could you share how you set it up? I am aware of those bugs, but I would like to play around with it asap. Still facing this issue: https://github.com/marklawlor/nativewind/issues/673

ammarfaris commented 11 months ago

PR is welcome

would it be better to update the existing starter (with-tailwind) or create a new one (something like with-nativewind-v4 ) ? @nandorojo

JWesorick commented 10 months ago

Anyone have NextJS App Directory working with Nativewind v4?

trevorpfiz commented 10 months ago

Anyone have NextJS App Directory working with Nativewind v4?

I tried, but I was having to add use client to the root layout.tsx file for some reason? There were some bugs and I planned to revisit it.

JWesorick commented 9 months ago

I got it working by just following the directions and then adding /** @jsxImportSource react */ to the top of my server components like layout.tsx and page.tsx. Also I updated to next@npm:14.1.0 [d369e] but not sure if that was required.

SantiMNV commented 5 months ago

I have just published a version with NextJS app router and Nativewind v4

https://github.com/SantiMNV/solito-nativewind-v4-app-router