search

nandorojo / solito

🧍‍♂️ React Native + Next.js, unified.
https://solito.dev
MIT License
3.35k stars 169 forks source link

target blank is not propagated to next/link #452

Closed seeden closed 6 months ago

seeden commented 7 months ago

Is there an existing issue for this?

Do you want this issue prioritized?

Current Behavior

When you use <Link href="/privacy" target="_blank"> it will show <a href="/privacy">

Expected Behavior

When you use <Link href="/privacy" target="_blank"> it will show <a href="/privacy" target="_blank">

Steps To Reproduce

import { Link } from 'solito/next'

return (Privacy);

Versions

- Solito: 4.1.2
- Next.js: 14.0.3
- Expo: 49.0.18
- React Native: 0.72.6

Screenshots

No response

Reproduction

No response

nandorojo commented 6 months ago

Published in 4.2.0: https://github.com/nandorojo/solito/releases/tag/v4.2.0

seeden commented 6 months ago

thank you @nandorojo

cglacet commented 4 months ago

Are you guys certain in works in 4.2.0?

I tested it with Next.js 13.5.6 but it doesn't seem to work for me.