Closed marklawlor closed 2 years ago
Someone is attempting to deploy a commit to a Personal Account owned by @nandorojo on Vercel.
@nandorojo first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
with-custom-fonts | âś… Ready (Inspect) | Visit Preview | Sep 5, 2022 at 11:54PM (UTC) |
Looks good. I'm indifferent about the folder structure, both ways seem equally correct.
Changes to the readme look good :+1:
I update the dep range of tailwindcss-react-native to latest, as it seems that's how much create-*-app examples work.
sweet. the latest
pattern technically gets broken by the yarn lock file (which is fine).
ideally it would install the latest
at the time someone runs the create script. however, this would require removing the lock file from the example app, and in my experience that causes many errors with react and such. next’s examples don’t have a lock file, but maybe it’s more complex with a monorepo
@nandorojo Hold off on merging this for a little bit. I've going to release a new version with a simpler API to create the custom components.
sounds good, let me know
@nandorojo This is good to review again. typography.tsx
and layout.tsx
have been rewritten to use defaultProps
instead of using wrapper components, reducing the overall render tree.
Interesting. I'm a bit up and down on the syntax there, since baseClassName
doesn't very clearly map onto style
anywhere. I'm more used to the typical react style that feels less magical, where you'd wrap the component itself.
const Center = styled(props => <Text {...props} className={`text-center ${props.className || ''}`} />)
How are we looking to get this merged? Anything left to do? I'd like to upgrade to sdk 45 on the blank example too.
This should be ready to merge, and you give it another look and let me know if things have changed.
I wonder if it’s because the resolution is in the wrong place, as my review of that PR suggested?
I wonder if it’s because the resolution is in the wrong place, as my review of that PR suggested?
I tried both, having the resolution in the packages/app
and in the root. I left it in the root per your suggestion. But, it wasn't until I blew away my cache, cleared the node_modules, and removed the lockfile in this PR, then everything started working correctly.
I wonder if it’s because the resolution is in the wrong place, as my review of that PR suggested?
For what it is worth, this is the repo I'm basing my new project off of. I actually didn't need to include the resolution after all, just add it as a dependency. https://github.com/0xBigBoss/solito-with-nativewind/blob/master/packages/app/package.json#L11
It has expo 46 and next 12.2.5 using solito and nativewind. Thanks a bunch everyone! Both PRs were very helpful.
@0xBigBoss what are the big differences between your repo and this PR?
I upgraded this to Next.js 12.3 + Expo SDK 46 successfully, and merged it via #140.
npx create-solito-app -t with-tailwind
I'll be doing a full announcement soon.
Amazing work @marklawlor!
Adds an example with nativewind
@expo/html-elements
doesn't work with RNW 0.18) so a newpackages/components
was created with examples on how to create custom components.