Closed thespacemanatee closed 1 year ago
thanks for the issue! is the menu item itself triggering the navigation?
oh i just saw the video, never mind.
hmm, is this native stack? what if you use normal text inside the trigger, same issue?
works fine for me with native stack, i wonder if there’s some special thing in your trigger? do you have enableFreeze(true)
?
@nandorojo thanks for the quick response! I am using the stack from react-navigation-shared-element
but it did not work when I used the regular stack and native stack from rn-navigation as well, and am not using enableFreeze(true)
. I'll add the relevant deps to the OP, and lmk if you need more information :)
hmm i see. i’m not too sure about what could cause it with that stack, especially since it isn’t maintained anymore
if you’re using native stack, it should work…maybe try toggling enableFreeze?
Tried native stack as well as toggling enableFreeze
to no avail :/ I understand if there's not much to go on here but maybe we could keep this issue up in case someone else encounters the same issue too. Not detaching the screen is an ok workaround for us atm.
did you try changing the trigger?
Happens with this Trigger
as well:
<DropdownMenu.Trigger>
<Text style={tw('text-white')}>Hello world</Text>
</DropdownMenu.Trigger>
https://user-images.githubusercontent.com/6837599/180464932-9da05fae-cf3c-444f-88b5-f42fed9e8138.mov
Ok so I'm getting a similar issue in my app of the trigger disappearing...it happens when i scroll far down a flatlist in my app. Will try to figure this out.
@thespacemanatee do you have fullScreenGestureEnabled
by chance? I think disabling this fixes it for me.
Also, does it happen both if you swipe back and press the back button?
@nandorojo Unfortunately I do not have fullScreenGestureEnabled
enabled and it happens both on swipe back and back button press
hmm got it, will keep investigating
Just confirming, are you on the latest version of react-native-ios-context-menu
?
Just confirming, are you on the latest version of
react-native-ios-context-menu
?
Yup, I was and still am on the latest version.
maybe we could cross-post on that repo?
i also assume memoizing doesn’t help on the zeego components?
maybe we could cross-post on that repo?
i also assume memoizing doesn’t help on the zeego components?
This is most likely about the same issue: https://github.com/dominicstop/react-native-ios-context-menu/issues/34
I will test out the patch provided in https://github.com/dominicstop/react-native-ios-context-menu/issues/34#issuecomment-1135781594 and submit a PR if that proves to fix the issue.
that definitely looks right. curious to see if it fixed it.
@nandorojo looks like its fixed with the latest version of react-native-ios-context-menu
!
@nandorojo
Confirming the comment above, looks like it works for some other use cases too! 🚀
I think this issue can be closed until further notice.
On iOS, when navigating from a screen that uses
DropdownMenu
to a new screen, and then going back to the previous screens, the components insideDropdownMenu.Trigger
disappears forever. See below for example and repro:Demo
https://user-images.githubusercontent.com/6837599/180454095-ef0fc707-8060-49dc-bac7-2d4790b45b4a.mov
Workaround
Set
detachPreviousScreen: false
on the next screen options which prevents theDropdownMenu
from detaching in the first place, but may cause performance problems.Repro
Dependencies