Closed fobos531 closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
zeego-docs | ✅ Ready (Inspect) | Visit Preview | Oct 17, 2022 at 7:12PM (UTC) |
Thanks for this! I'm just now seeing it (my notifications on GitHub are crazy rn haha). I'd like to make the following changes:
ios
iosIconName
in favor of ios.name
iosIconName
, but the TSDoc comment should mark it as deprecated/**
* @deprecated Please use the `name` inside of the `ios` prop instead.
*/
iosIconName?: string
In v1, I can release this as a breaking change.
Hey @nandorojo , thanks for looking at this! I have applied your suggestions, also please see comments made to your review. Let me know if you'd want anything changed.
Could you resolve the merge conflicts? Just need to fix the package.json and run yarn
. I can merge after that.
@nandorojo Good to go!
Resolves #19
As per our conversation, the purpose of this PR is to add extensive customization to SF Symbols provided internally by
react-native-ios-context-menu
. We're talking icon weight, scale, colors etc. Examples:I've updated the types as well as the example app. I noticed small bits of repetition in some types so I extracted those as a common type. My only gripe (with TypeScript) is I can't seem to figure out how to properly omit the
systemName
property fromImageSystemConfig
type (seepackages/zeego/src/menu/types.ts
, L74). Basically we need to remove this since we're passing the icon name throughiosIconName
, but still have proper autocompletion for the type. I'd appreciate input on that front!Let me know if you need anything else from me.