search

nandorojo / zeego

Menus for React (Native) done right.
https://zeego.dev
MIT License
1.42k stars 41 forks source link

CheckboxItem not displaying check icon on Android #45

Closed Estevete closed 3 months ago

Estevete commented 1 year ago

Code

<DropdownMenuCheckboxItem
    key="test"
    textValue="TEST"
    value={true}>
    <DropdownMenu.ItemIndicator>
        <CheckmarkIcon />
    </DropdownMenu.ItemIndicator>

    <Text>TEST</Text>
</DropdownMenuCheckboxItem>

Current behavior CheckboxItem is not displaying the check icon on Android. On iOS & web it works well

Android: image

iOS: image

Web: image

Expected behavior CheckboxItem displays the check icon on Android

nandorojo commented 1 year ago

hmm interesting…I believe @intergalacticspacehighway did the android integration with react-native-menu, maybe he’ll have some insight.

alantoa commented 1 year ago

@Estevete no way because Android doesn't support custom icons yet; it only supports the default Android system icons lol.

CleanShot 2023-05-12 at 1 33 06

nandorojo commented 1 year ago

we should still use a checkmark icon here though right?

Estevete commented 1 year ago

we should still use a checkmark icon here though right?

I think so, yep

alantoa commented 1 year ago

yes!

Darren120 commented 9 months ago

updates?

nandorojo commented 9 months ago

Open to a PR here.

MarceloPrado commented 3 months ago

I can work on a PR for this - do we have any particular guidance @nandorojo ?

nandorojo commented 3 months ago

It would be in createAndroidMenu, it’s possible something isn’t passing properly to react-native-menu

MarceloPrado commented 3 months ago

@nandorojo done!

nandorojo commented 3 months ago

Released in 1.10: https://github.com/nandorojo/zeego/releases/tag/v1.10.0