search

nandorojo / zeego

Menus for React (Native) done right.
https://zeego.dev
MIT License
1.42k stars 41 forks source link

ContextMenu trigger onclick too #59

Open AlejandroGutierrezB opened 9 months ago

AlejandroGutierrezB commented 9 months ago

trying this example https://github.com/nandorojo/zeego/blob/master/examples/expo/src/App.tsx

When I do a normal click on the contextMenu the dropdown is shown (with some delay).

Expected behaviour is for this not to happen

rranjan14 commented 9 months ago

It's happening with me in android. Also, long press is not triggering context menu after first open.

nandorojo commented 9 months ago

Hi! Can you please clarify the problem and what the platform is @AlejandroGutierrezB? I don't have enough info here. Are you saying that tapping the menu opens the context menu when it should only be on long press? I assume this is Android?

AlejandroGutierrezB commented 9 months ago

Hi! Can you please clarify the problem and what the platform is @AlejandroGutierrezB? I don't have enough info here. Are you saying that tapping the menu opens the context menu when it should only be on long press? I assume this is Android?

Hi @nandorojo sorry for not been detailed enough.

My issue is for Web, Haven't really tested in android so can't talk about that.

when clicking there is a small delay and the menu is triggered. That is the unexpected behaviour as I don't want to open the menu when clicking. when long-clicking the menu is instantly triggered as expected.

nandorojo commented 9 months ago

context menu should open on right click. is that not what’s happening?

Karthik-B-06 commented 5 months ago

Hey @nandorojo, using ContextMenu Menu on Android gets triggered onClick too. Here is a video showing what is happening.

https://github.com/nandorojo/zeego/assets/35562287/96774216-7a43-4d57-a929-85f7da7a25cf

The Context.Trigger is also wrapped inside a LightBox component.

ICGVIP commented 2 weeks ago

Hey @nandorojo, using ContextMenu Menu on Android gets triggered onClick too. Here is a video showing what is happening.

VIDEO-2024-01-15-16-07-52.mp4

The Context.Trigger is also wrapped inside a LightBox component.

This is happening with me in iOS too. ContextMenu.Trigger wraps an entire component with different images in my case and long pressing any image, opens it (onPress gets fired basically) along with opening the context menu.