nandorojo / zeego

Menus for React (Native) done right.
https://zeego.dev
MIT License
1.42k stars 41 forks source link

Icons have shrunk on iOS 17 / Xcode 15 #60

Open branaust opened 9 months ago

branaust commented 9 months ago

Icons were working perfectly prior to upgrading to Xcode 15 and iOS 17. Below is a before and after of what our icons looked like:

BEFORE AFTER

implementation:

import { Icon } from '@ntwrk1/design-system';
import React from 'react';
import { Pressable, StyleSheet, Text } from 'react-native';

import { PrimaryColorPalette } from 'assets/colors';
import * as DropdownMenu from 'zeego/dropdown-menu';

export default function CompletedShowMenu({
  onDelete,
}: {
  onDelete: () => void;
}) {
  return (
    <DropdownMenu.Root>
      <DropdownMenu.Trigger action="press">
        <Pressable style={styles.triggerButton}>
          <Icon color={PrimaryColorPalette.MAIN_1} variant="MoreVertical" />
        </Pressable>
      </DropdownMenu.Trigger>

      <DropdownMenu.Content>
        <DropdownMenu.Item
          destructive
          key="remove"
          onSelect={onDelete}
          textValue="Remove"
        >
          <DropdownMenu.ItemTitle>
            <Text>Remove</Text>
          </DropdownMenu.ItemTitle>
          <DropdownMenu.ItemIcon
            ios={{
              name: 'trash',
              pointSize: 5,
              weight: 'semibold',
              scale: 'default',
            }}
          />
        </DropdownMenu.Item>
      </DropdownMenu.Content>
    </DropdownMenu.Root>
  );
}

const styles = StyleSheet.create({
  triggerButton: {
    height: 28,
    width: 28,
    justifyContent: 'center',
    alignItems: 'center',
    borderRadius: 50,
    borderColor: PrimaryColorPalette.MAIN_5,
    borderWidth: 1,
    transform: [{ rotate: '90deg' }],
  },
});

Xcode version 15.0 Simulator: iPhone 15 Pro

nandorojo commented 9 months ago

that’s not good. can you open an issue on the upstream ios library?

nandorojo commented 9 months ago

We are investigating this issue over the next few days.

nandorojo commented 8 months ago

This hasn't happened on our app for iOS 17, but I'm also on an iPhone 13 so that may be why.

fobos531 commented 8 months ago

Cannot reproduce on iPhone 14 Pro 17.0.3 - real device Also not seeing it on Simulator - iPhone 14 Pro 17.0

nandorojo commented 8 months ago

Same, all of this works for me. Could you provide a reproduction? Going to close otherwise.