nandtotetris / computer-visualizer

0 stars 0 forks source link

build: add standard package and configurations #9

Closed henites72 closed 4 years ago

henites72 commented 4 years ago

Fixes #8

I did, standard --fix on the base directory, to fix the lint errors.

henites72 commented 4 years ago

@Buranch you can install standard globally and run, standard --fix. Let me know if this is what you want?

Buranch commented 4 years ago

@henites72 yes, but let's not relay on global packages. One of us may not install it. Its good to have it on package.json.

mezzzi commented 4 years ago

Yes, I agree with @Buranch . Let's add standard as a dev dependency (we shouldn't expect devs to install standard globally). Also let's have a script that runs standard. It will be run later as part of the build. We can update package.json as follows:

  "devDependencies": {
    "standard": "*"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject",
    "standard": "standard"
  },
mezzzi commented 4 years ago

And when I run npm run standard I got the following errors: Screenshot from 2020-02-29 11-33-30 Screenshot from 2020-02-29 11-34-00

Buranch commented 4 years ago

@mezzzi did the error got fixed?

Buranch commented 4 years ago

@henites72 @mezzzi I've added a fix for the error @mezzzi and I was facing.