Closed amaltson closed 10 years ago
It looks like there was some credentials fixes for secure connections based on the diff of the fork. Might not be necessary any more but @nandub should comment on that.
Agree with @jgable, however is been a while since I did that.
The change I made to my fork never made to upstream so not sure by going to the NPM version will break and have a problem again. Can we use http:// instead of git://?
Npm does not work with http links on dependencies. Ok lets change it to NPM package and see what breaks.
I found it does work, you have to change the URL to "git+https://....". The npm package.json docs talk about it. Can't find the link now.
Arthur Maltson Sent from my iPhone
On Dec 4, 2013, at 1:34 PM, Fernando Ortiz notifications@github.com wrote:
Npm does not work with http links on dependencies. Ok lets change it to NPM package and see what breaks.
— Reply to this email directly or view it on GitHubhttps://github.com/nandub/hubot-irc/pull/102#issuecomment-29831595 .
Right, can you update your PR to use the format described in the npm docs. I can merge that in pretty quickly once you do that.
Thanks @amaltson for figuring that out. I got lazy about reading the npm document. I was about to check on it when I refresh the window and saw your reply.
@nandub no problem, pushed up.
Thanks. Published as 0.1.24.
Confirmed to work behind firewall, thanks!
When I try to install this behind the firewall, the
git://
protocol version can't be installed by npm. I tried theirc
version in npm and it works fine, any reason to use your fork?