search

nandub / hubot-irc

IRC adapter for Hubot
MIT License
299 stars 128 forks source link

Add support for distinguishing emotes from regular actions #109

Closed jasonmay closed 10 years ago

jasonmay commented 10 years ago

I'm not sure this solution fits in the hubot-irc core, as it disrupts how people would currently use hubot-irc to track regular messages and ACTION messages together. If people relied receiving both as TextMessages, people will stop receiving emotes in their listners. That said, it feels right as a solution. That, or simply adding a property that denotes that the TextMessage object is an emote.

https://gist.github.com/jasonmay/663901032394dea7ac25 is an example hubot script that tests it.

jgable commented 10 years ago

Interesting, is EmoteMessage a recently implemented thing in Hubot? How is it used in other adapters like the CampfireAdapter?

jasonmay commented 10 years ago

It depends on jasonmay/hubot@1077043 (github/hubot#650) and was written in response to issue #92. I haven't tested with the campfire adapter yet, just IRC so far.

jgable commented 10 years ago

I don't think we should add a dependency on your fork of Hubot, but if you can get the EmoteMessage into Hubot core I'd merge this.