search

nandub / hubot-irc

IRC adapter for Hubot
MIT License
299 stars 128 forks source link

Install fails on optional dep node-icu-charset-detector #156

Open tsde opened 9 years ago

tsde commented 9 years ago

Hi,

When trying to install hubot-irc, I'm getting the following warning:

.../...
node-icu-charset-detector.target.mk:86: recipe for target 'Release/obj.target/node-icu-charset-detector/node-icu-charset-detector.o' failed
.../...
npm WARN optional dep failed, continuing node-icu-charset-detector@0.0.7

node-icu-charset-detector is an optional dep of the irc module you're using for hubot-irc. The issue seems to be fixed if we use version 0.4.0 of the irc module. I see that you recently updated your package.json with this version in your master branch but hubot-irc tagged 0.2.8 still ships with version 0.3.9 of the irc module.

I know that this is not really a critical error but do you have any plans on updating irc module version so we can install hubot-irc without warning ?

FYI, I'm using node v4.2.1

Cheers

rodrigoaguilera commented 8 years ago

Please release a new version that fixes this

deftdawg commented 8 years ago

I'm hitting this issue too with node 6.0 on Debian as well... It would be nice if node did not attempt to recompile these broken modules each time hubot starts, it delays start-up by like 3 minutes on my slow embedded system

lagbox commented 6 years ago

2 years later

chrisdotcode commented 6 years ago

@lagbox Is this not resolved in the latest master?