search

nandub / hubot-irc

IRC adapter for Hubot
MIT License
299 stars 128 forks source link

multiple connect commands #159

Closed matschundbrei closed 7 years ago

matschundbrei commented 8 years ago

Added the possibility to send multiple semicolon separated connect commands. Hacked that to be able to login to Q and switch to incognito-mode over at Quakenet, Cheers!

chrisdotcode commented 7 years ago

This is a good idea - I'm not a domain expert on sending multiple commands, but is a single string the most robust way we do this? What about potentially passing in an array?

chrisdotcode commented 7 years ago

@matschundbrei, I'd love to see this implemented, but seeing as this is a super stale PR, I'm going to close this. If you are still interested in completing this (and apologies for the delay in getting you an update), please feel free to re-open!

matschundbrei commented 7 years ago

Hey, There's always other stuff to do, so no worries about the delay.

Just to verify, that I understood you correctly:

Let's make the passed option to be either an array (from a bash environment variable?) or a string for which it will be interpreted as a single command otherwise a command will be passed for each element of the array.

Is that what you meant by "What about potentially passing in an array?" ?

If so I can see if I can spare some time to implement it.