search

nandyalu / trailarr

Trailarr is a Docker application to download and manage trailers for your Radarr and Sonarr libraries.
GNU General Public License v3.0
108 stars 7 forks source link

[Bug] Edge case where media with "/" in title fails to move downloaded trailers #33

Closed Jdiesel87 closed 1 month ago

Jdiesel87 commented 1 month ago

Media with a / in the title fail to move due to the / being carried over to the creation of trailers directory. For example the movie "Crazy/Beautiful" is attempting to be created at /movies/crazy beautiful (2001)/trailers/crazy/beautiful/trailer.mkv

This issue likely does not occur if you are using trailer folders. 

2024-08-29T10:05:52-0600 [INFO|base|L144]: Job "Download Missing Trailers (trigger: interval[1:00:00], next run at: 2024-08-29 11:05:23 CST)" executed successfully

2024-08-29T10:05:52-0600 [INFO|download_trailers|L061]: TrailerDownloadTasks: No missing series trailers to download

2024-08-29T10:05:52-0600 [INFO|download_trailers|L067]: TrailerDownloadTasks: No movies trailers downloaded

2024-08-29T10:05:52-0600 [INFO|trailer|L244]: TrailersDownloader: Downloaded trailers for 0 movies

2024-08-29T10:05:52-0600 [INFO|trailer|L242]: TrailersDownloader: Trailer download failed for '[546]Frost/Nixon'

2024-08-29T10:05:52-0600 [ERROR|trailer|L143]: TrailersDownloader: Failed to move trailer to folder: [Errno 2] No such file or directory: '/Storage/media/movies/FrostNixon (2008)/Trailers/Frost/Nixon - Trailer-trailer.mkv'

2024-08-29T10:05:41-0600 [INFO|trailer|L234]: TrailersDownloader: Downloading trailer for '[546]Frost/Nixon'...

2024-08-29T10:05:41-0600 [INFO|trailer|L242]: TrailersDownloader: Trailer download failed for '[495]Fahrenheit 9/11'

2024-08-29T10:05:41-0600 [ERROR|trailer|L143]: TrailersDownloader: Failed to move trailer to folder: [Errno 2] No such file or directory: '/Storage/media/movies/Fahrenheit 911 (2004)/Trailers/Fahrenheit 9/11 - Trailer-trailer.mkv'

2024-08-29T10:05:36-0600 [INFO|trailer|L234]: TrailersDownloader: Downloading trailer for '[495]Fahrenheit 9/11'...

2024-08-29T10:05:36-0600 [INFO|trailer|L242]: TrailersDownloader: Trailer download failed for '[346]Crazy/Beautiful'

2024-08-29T10:05:36-0600 [ERROR|trailer|L143]: TrailersDownloader: Failed to move trailer to folder: [Errno 2] No such file or directory: '/Storage/media/movies/Crazy Beautiful (2001)/Trailers/Crazy/Beautiful - Trailer-trailer.mkv'

2024-08-29T10:05:23-0600 [INFO|trailer|L234]: TrailersDownloader: Downloading trailer for '[346]Crazy/Beautiful'...

2024-08-29T10:05:23-0600 [INFO|trailer|L222]: TrailersDownloader: Downloading trailers for 3 monitored movies...
nandyalu commented 1 month ago

Added a check to remove any unsupported characters from trailer file name. PR #30 fixes this

Jdiesel87 commented 1 month ago

Fixed confirmed working. Thanks

2024-08-29T11:42:19-0600 [INFO|trailer|L255]: TrailersDownloader: Downloading trailer for '[546]Frost/Nixon'...

2024-08-29T11:42:19-0600 [INFO|trailer|L259]: TrailersDownloader: Trailer downloaded for '[495]Fahrenheit 9/11' from [lQm4efsmVGA]

2024-08-29T11:42:12-0600 [INFO|trailer|L255]: TrailersDownloader: Downloading trailer for '[495]Fahrenheit 9/11'...

2024-08-29T11:42:12-0600 [INFO|trailer|L259]: TrailersDownloader: Trailer downloaded for '[346]Crazy/Beautiful' from [NuUiO85Xva0]

2024-08-29T11:42:00-0600 [INFO|trailer|L255]: TrailersDownloader: Downloading trailer for '[346]Crazy/Beautiful'...

2024-08-29T11:42:00-0600 [INFO|trailer|L243]: TrailersDownloader: Downloading trailers for 3 monitored movies...

2024-08-29T11:42:00-0600 [INFO|download_trailers|L088]: TrailerDownloadTasks: Downloading missing trailers