search

nandyalu / trailarr

Trailarr is a Docker application to download and manage trailers for your Radarr and Sonarr libraries.
GNU General Public License v3.0
108 stars 7 forks source link

[Bug] Notificatrion says "Trailer downloaded successfully" despite it failing. #56

Open alexkahler opened 3 weeks ago

alexkahler commented 3 weeks ago

Describe the bug Pop-up notification says trailers have downloaded successfully, but no trailers are downloaded. Logs shows that the job had, in fact, failed.

Edit: Specifically, it says "Download Trailer for XXX Task Finished" in a green pop-up. To many, this behavior would equal that the download finished successfully (even though this was not the case), and as such, become confused when they are unable to find the downloaded trailer. Logs also show the last line as "Job "Download Trailer for XXX (trigger: date[YYYY-MM-DD], next run at: YYYY-MM-DD)" executed successfully

Steps To Reproduce Steps to reproduce the behavior: Download a trailer. Queuing multiple trailers downloads in row manually seems to aggravate the chances of a download failing.

Actual behavior Pop-up notification always pops up as a green "success" no matter if the job failed or succeeded.

Expected behavior Pop-up notification stating the actual download status, and potential reason why it failed (if it failed).

Screenshots image

App Information (please complete the following information):

Additional context Logs:

2024-10-01T13:52:35+0200 [INFO|series|L088]: Downloading trailer for series with ID: 677 from [uiKELYu1obk]
2024-10-01T13:52:35+0200 [INFO|download_trailers|L140]: TrailerDownloadTasks: Downloading trailer for series ID: 677
2024-10-01T13:52:35+0200 [INFO|base|L895]: Added job "Download Trailer for Shrinking" to job store "default"
2024-10-01T13:52:35+0200 [INFO|download_trailers|L180]: TrailerDownloadTasks: Trailer download started in background for series: 'Shrinking' (ID: 677) from [uiKELYu1obk]
2024-10-01T13:52:36+0200 [INFO|base|L641]: Removed job download_trailer_by_id_677_False
2024-10-01T13:52:36+0200 [INFO|base|L123]: Running job "Download Trailer for Shrinking (trigger: date[2024-10-01], next run at: 2024-10-01)" (scheduled at 2024-10-01)
2024-10-01T13:52:36+0200 [INFO|trailer|L328]: TrailersDownloader: Downloading trailers for 1 monitored series...
2024-10-01T13:52:36+0200 [INFO|trailer|L340]: TrailersDownloader: Downloading trailer for '[677]Shrinking'...
2024-10-01T13:52:39+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SponsorBlock] Converting downloaded file...
2024-10-01T13:52:39+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SponsorBlock] Converting downloaded file...
2024-10-01T13:52:39+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SubtitlesConvertor] Converting downloaded file...
2024-10-01T13:52:39+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SubtitlesConvertor] Converting downloaded file...
2024-10-01T13:52:54+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SponsorBlock] Converting downloaded file...
2024-10-01T13:52:54+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SponsorBlock] Converting downloaded file...
2024-10-01T13:52:55+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SubtitlesConvertor] Converting downloaded file...
2024-10-01T13:52:55+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SubtitlesConvertor] Converting downloaded file...
2024-10-01T13:53:06+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SponsorBlock] Converting downloaded file...
2024-10-01T13:53:06+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SponsorBlock] Converting downloaded file...
2024-10-01T13:53:06+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SubtitlesConvertor] Converting downloaded file...
2024-10-01T13:53:06+0200 [INFO|video|L042]: TrailersDownloader: 'Trailers': [SubtitlesConvertor] Converting downloaded file...
2024-10-01T13:53:06+0200 [INFO|trailer|L348]: TrailersDownloader: Trailer download failed for '[677]Shrinking'
2024-10-01T13:53:06+0200 [INFO|trailer|L350]: TrailersDownloader: Downloaded trailers for 0 series
2024-10-01T13:53:06+0200 [INFO|download_trailers|L109]: TrailerDownloadTasks: Trailer download failed!
2024-10-01T13:53:06+0200 [INFO|base|L144]: Job "Download Trailer for Shrinking (trigger: date[2024-10-01], next run at: 2024-10-01)" executed successfully
nandyalu commented 3 days ago

That notification actually says task finished, not "trailer download successfully".

It is possible to add notifications for each trailer download, but do we really need that?

Consider this scenario: App is running "Download Missing Trailers" task when 50 trailers are missing, if we add individual trailer download notifications, it's going to show 50 notifications. So, instead it shows task started and task finished notifications only.

Please let me know your thoughts!