Pre work for Swift Coderschool

nangtrongvuon / tips

a tip calculator made with swift

0 stars 0 forks source link

Pre work for Swift Coderschool #1

Open nangtrongvuon opened 8 years ago

nangtrongvuon commented 8 years ago

Here is my prework for CoderSchool's Swift course.

/cc @coderschoolreview

coderschoolreview commented 8 years ago

Thank you for your Swift submission, nangtrongvuon!

:laughing: Everything looks good with the format of your submission. We'll be reviewing your submission soon!

coderschoolreview commented 8 years ago

:+1: Great job with the Tip Calculator!

Quick Comments:

Wow, good job with autoLayout. We will learn that in W2.
Your app UI looks good :smile:
Your code is neat and clean.
Good usage of NSUserDefaults. This is one of the methods to pass the data from multiple viewController. We will learn few more ways to do that.
You shouldn't let the user enter invalid number, should you? I can enter bunch of leading zeros, and the dots. I can also paste some text in the text field.

We will email you soon with information about the class.

nangtrongvuon commented 8 years ago

Thanks for the kind comments. Do you have any suggestions to fix the UITextField problem? I was thinking of RegEx but I don't think it's a very elegant solution.

nangtrongvuon commented 8 years ago

I think I have implemented a fix. Using UITextFieldDelegate, all invalid inputs (such as multiple decimals and letters) are now deleted. Please check the app again.

coderschoolreview commented 8 years ago

:+1: Good job using delegate. This is the way to listen to the event.