nanihadesuka / NovelDokusha

Android web novel reader
GNU General Public License v3.0
239 stars 18 forks source link

Doesn't render margin correctly #88

Closed tengkuizdihar closed 1 year ago

tengkuizdihar commented 1 year ago

Description

It seems like the client doesn't render margin correctly if there's a margin in the epub. Is there a way for the margin to be properly rendered, or is it a limitation of the library being used to render it?

You can use the attached epub as an example. epubfortesting.zip

Screenshot

Using Foliate (linux)

image

Using NovelDokusha (android)

image

nanihadesuka commented 1 year ago

This is expected. All the extra margin, bold text, italic text is stripped when imported into the app. I didn't add these extra features as it would bring more complexity than I'm willing to work on.

I don't discard adding it in the future though.

Will set as won't fix as is not a bug or critically needed.

nanihadesuka commented 1 year ago

@tengkuizdihar nice avatar profile :D (fire punch)

tengkuizdihar commented 1 year ago

Well thank you for the clarification, I really like your app! It's very minimalist and easy to use. Would hope that it could support something like bold, italics, and some simple margins, oh well. I was just suggesting to use something like https://github.com/readium/kotlin-toolkit to display it so you don't have to maintain too much of the "displaying" part of the codebase.

tengkuizdihar commented 1 year ago

Also, very based license my friend https://github.com/nanihadesuka/NovelDokusha/blob/master/LICENSE