search

nanikit / BetterSort

Beat saber plugin that adds last played date sort.
MIT License
7 stars 2 forks source link

Skip replay record for BeatLeader replays #5

Closed karghoff-e closed 2 years ago

nanikit commented 2 years ago

Did you test it? I tested against beatleader-mod master branch but it didn't detect replay status.

The following is some related log of my test. All plays are beatleader replay, 1.25.0, and I used SiraUtil fpfc.

[ERROR @ 15:02:50 | BeatLeader] Failed to resolve Camera2 data, replays system may conflict with Camera2!
[DEBUG @ 15:02:50 | BetterSort.LastPlayed] Initialize()
[INFO @ 15:02:50 | BetterSort.LastPlayed] Loaded 960 records
[DEBUG @ 15:02:50 | BetterSort.LastPlayed] Registered last play date sorter.
[INFO @ 15:02:50 | BetterSort.LastPlayed] Initialized.
[INFO @ 15:03:38 | BetterSort.LastPlayed] Skip record due to too short play: Queen
[INFO @ 15:10:52 | BetterSort.LastPlayed] Dispatch play event: Queen
[DEBUG @ 15:10:52 | BetterSort.LastPlayed] Record play custom_level_BFD56AD122151AFEF6F763EA6DEE5BD36EFCE9C2: 2022-10-10 PM 3:10:52
[INFO @ 15:10:52 | BetterSort.LastPlayed] Saved 960 records
[INFO @ 15:13:28 | BetterSort.LastPlayed] Skip record due to too short play: Monsters
[INFO @ 15:13:47 | BetterSort.LastPlayed] Skip record due to too short play: Dimension Hacker

There may be code execution order difference (between beatleader's property change and this plugin's check).

nanikit commented 2 years ago

Never mind. Plugin wasn't copied to my game directory and I rechecked it works. Thanks for you work.