search

nanit / kubernetes-rabbitmq-cluster

Deploy-ready rabbitmq cluster for kubernetes
MIT License
197 stars 84 forks source link

Added POD_MEMORY_SIZE as a configurable value #35

Closed mikepc closed 4 years ago

erez-rabih commented 5 years ago

Hi thanks for the PR I would like to merge but I think the environment variable could be better - maybe POD_MEMORY_REQUEST ? I'm saying that thinking of the future when someone else would need to add memory limit and even cpu requests/limits

mikepc commented 5 years ago

I'll update this tonight!

On Sun, Nov 18, 2018 at 11:05 PM erez notifications@github.com wrote:

@erez-rabih requested changes on this pull request.

please review the environment variable name

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nanit/kubernetes-rabbitmq-cluster/pull/35#pullrequestreview-176163796, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1ok9_ZP-VNc8trrBbpYnTdIBIYoEbQks5uwlhJgaJpZM4YoKfx .

daanl commented 5 years ago

Hi, would it be possible to merge it? 5GB seems way to much for simpel cluster :-)