nanite / BetterCompatibilityChecker

Other
12 stars 5 forks source link

[Feature Request] Customizable message when server does not have BetterCompatibiltyChecker Mod #17

Closed Kanzaji closed 1 year ago

Kanzaji commented 1 year ago

Suggestion Description

From my testing, the mod is "disabled" when server part does not have the mod installed. It would be nice if the mod prompt would use the Forge Modlist checker to determine if the modlist is correct, but still show the warning the modpack could be on different version, with additional note (like latest version of the modpack that doesn't contain the mod, or customizable note from Dev)

Why I would like this feature?

I think it would be really useful for packs that have been already released, but they did not add this mod from the first version 😅

MichaelHillcox commented 1 year ago

From what I know, the way this mod works is by having the server tell the client they are different. If the server can't do this by modifying the incoming packet, then the client has no way of actually knowing what version the server is on.

Gaz492 commented 1 year ago

In addition to what Michael said, the mod data sent by forge to calculate the cross/tick has not been very accurate in older versions due to packet size limits, which is the reason I made this mod.

Kanzaji commented 1 year ago

I understand all the limitations, and I understand how the mod works 😅 But I was talking more of like a fallback when the mod is not present on the server, but it is on the Client. We all know the Forge mod data is not great, but it is something, and can be used as a fallback with custom message specified in the config, like "The server is at least on version 1.3.0 or lower" for the packs that added the mod later on. If that still doesn't make much sense let me know 😄

PS: The entire mention about Forge detecting thing was only for the indicator of the modlist being compatible, but this could be technically completely ignored, and replaced with an X or with yellow warning sign or something like that when the server does not have the mod installed 😄

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 2 days.

Kanzaji commented 1 year ago

Any news on that 👀?

MichaelHillcox commented 1 year ago

I understand all the limitations

The issue here is that we don't have this data. We don't know what the lowest version the server would be running. If the server can not provide us the right info (which requires the server to be running the mod) we simply can't do anything.

Kanzaji commented 1 year ago

Modpack dev however can do it in the config for client-side, and that is what I'm asking about 😄 The message would look something like this:

When server has BetterCompatibilityChecker: obraz

When server does not have BetterCompatibiltiChecker but modpack dev provided first version that has it installed. (Or custom message, tbh I think custom one could be a bit better but it's your choice.) obraz (Perfect Photoshop skills I know 😆)

Jake-E commented 1 year ago

Modpack dev however can do it in the config for client-side, and that is what I'm asking about 😄 The message would look something like this:

When server has BetterCompatibilityChecker: obraz

When server does not have BetterCompatibiltiChecker but modpack dev provided first version that has it installed. (Or custom message, tbh I think custom one could be a bit better but it's your choice.) obraz (Perfect Photoshop skills I know 😆)

And how would the mod know that it's below 1.3.0? What if it's on 1.5.0? How would it even know it's Enigmatica 9?

Kanzaji commented 1 year ago

That was just an example ^^" I had in mind the version can be set in the config and it will take Name + first version of the pack that has the mod from there and show it if the server doesn't have bcc installed. That being clientsided and optional ^^

Jake-E commented 1 year ago

Unfortunately, I don't think this is something that the team plans on adding. Thanks for the suggestion though :)