nanite / Compressium

Compressed Blocks For Minecraft
3 stars 4 forks source link

[Issue] Custom Blocks Appear with the null texture and are uncraftable #7

Open TheKidThatCodes opened 2 years ago

TheKidThatCodes commented 2 years ago

Mod version

Compressium-1.4.1-build.6+mc1.18.2.jar from curseforge

Forge mod loader version

40.1.23

Repeatable?

Link to log files

it does not appear in logs

Steps to reproduce the issue

add a custom block to the json on server and client (i did copper, tuff, cobbled_deepslate, deepslate)

{
    "name": "copper_block",
    "nestedDepth": 9,
    "isBlockOf": false,
    "baseResourceLocation": "minecraft:copper_block",
    "particlePath": "minecraft:block/copper_block",
    "baseBlockModel": "minecraft:block/copper_block",
    "type": "block"
  },

look at it in jei see to your dismay that it has the null block texture and is not craftable

Description of the issue you are having

custom blocks appear as null and have a language file tag as name and are uncraftable

Information

DinnerBeef commented 2 years ago

Is this for all of them? Or just the copper block? There is no reason to add copper blocks as I all ready do that my self

TheKidThatCodes commented 2 years ago

i only actually added tuff, cobbled_deepslate, deepslate but yes, they are all null

TheKidThatCodes commented 2 years ago

i made python script that i give it modids and blockids and it fills out a template to make compressium blocks

DinnerBeef commented 2 years ago

can you send your config so I can test it please

TheKidThatCodes commented 2 years ago

i deleted it so my friends could join. i will try to replicate it

TheKidThatCodes commented 2 years ago

add this to your config:

{
    "name": "deepslate",
    "nestedDepth": 9,
    "isBlockOf": false,
    "baseResourceLocation": "minecraft:deepslate",
    "particlePath": "minecraft:block/deepslate",
    "baseBlockModel": "minecraft:block/deepslate",
    "type": "block"
  },

{
    "name": "tuff",
    "nestedDepth": 9,
    "isBlockOf": false,
    "baseResourceLocation": "minecraft:tuff",
    "particlePath": "minecraft:block/tuff",
    "baseBlockModel": "minecraft:block/tuff",
    "type": "block"
  },

{
    "name": "amethyst_block",
    "nestedDepth": 9,
    "isBlockOf": false,
    "baseResourceLocation": "minecraft:amethyst_block",
    "particlePath": "minecraft:block/amethyst_block",
    "baseBlockModel": "minecraft:block/amethyst_block",
    "type": "block"
  },

{
    "name": "cobbled_deepslate",
    "nestedDepth": 9,
    "isBlockOf": false,
    "baseResourceLocation": "minecraft:cobbled_deepslate",
    "particlePath": "minecraft:block/cobbled_deepslate",
    "baseBlockModel": "minecraft:block/cobbled_deepslate",
    "type": "block"
  },
ghost commented 2 years ago

I also have the same issue trying to add any other block. Tuff is the only thing I've added I currently have in my compressiumblocks.json file and checkerboard textures show up without a recipe attached to them.


    "name": "granite",
    "nestedDepth": 9,
    "isBlockOf": true,
    "baseResourceLocation": "minecraft:granite",
    "particlePath": "minecraft:block/granite",
    "baseBlockModel": "minecraft:block/granite",
    "type": "block"
  },
  {
    "name": "tuff",
    "nestedDepth": 9,
    "isBlockOf": true,
    "baseResourceLocation": "minecraft:tuff",
    "particlePath": "minecraft:block/tuff",
    "baseBlockModel": "minecraft:block/tuff",
    "type": "block"
  }
]
DinnerBeef commented 2 years ago

Will look into this at some point busy with other things atm

ghost commented 2 years ago

Hopefully this helps in the future. I figured out that forge doesn't seem to generate the new data relating to an added block in the listing. When I ran "runData" within my IDE it generated it and fixed the issue. image

PeasantZi11a commented 2 years ago

DeimosMoons, how do you go about actually putting all the code into the IDE and running it to generate the necessary data? Also which IDE are you using?

HalcyonSeas73 commented 2 years ago

DeimosMoons, how do you go about actually putting all the code into the IDE and running it to generate the necessary data? Also which IDE are you using?

They look to be using IntelliJ/JetBrains as an IDE. They appear have Minecraft Forge MDK open.

Hopefully @DinnerBeef can get this fixed soon.

PeasantZi11a commented 2 years ago

@HalcyonSeas73 do you know how to actually replicate what they are doing? If so would you mind explaining to me? I only took an introductory java course and only know basic coding, nothing about compilation/decomp

HalcyonSeas73 commented 2 years ago

@HalcyonSeas73 do you know how to actually replicate what they are doing? If so would you mind explaining to me? I only took an introductory java course and only know basic coding, nothing about compilation/decomp

I'm in the same boat as you; introductory java. I don't know anything about it.

scottwaffles commented 1 year ago

I am also curious about this. Seems to not have changed in the recent update at all as I have the missing textures in JEI and no recipe appearing.

Waterspark63 commented 1 year ago

Not entirely sure how hard or easy it would be as I know almost nothing about mc modding, but for the missing blockstate & other files it needs to actually create the models for custom blocks, would it be possible to have them be in the config folder, in a compressium folder or something so when someone wants to add a custom block, they just have to copy/make another blockstate, etc files, kind of like how Resource Chickens works? Or maybe just read from the block's source and referencing the information from the source, instead of having it's own copy of all the data? Maybe support through datapacks? If I'm speaking nonsense, please let me know ^^;

Waterspark63 commented 1 year ago

Another alternative if possible, is either KubeJS or craft tweaker support, if it's possible to make a compat layer that makes it easier to make custom compressed blocks, that could be a viable option (at the same time, using those mods, you could do it yourself as well as a player/modpack creator)