nanite / JAVD

0 stars 3 forks source link

Fix tag problem on Fabric #11

Closed EvanHsieh0415 closed 1 year ago

EvanHsieh0415 commented 1 year ago

#forge:obsidian -> #c:obsidian

UnRealDinnerbone commented 1 year ago

While this is an option, I think the best solution would be to make a new tag that contains both the c:obsidian and forge:obsidian tag as not have different recipes

UnRealDinnerbone commented 1 year ago

also what mod as c:obsidian

EvanHsieh0415 commented 1 year ago

While this is an option, I think the best solution would be to make a new tag that contains both the c:obsidian and forge:obsidian tag as not have different recipes

This is the method I use in my data pack: define a c tag and include both c and forge tags.

// data/c/tags/items/obsidian.json
{
  "replace": false,
  "values": [
    "minecraft:obsidian",
    {
      "value": "#forge:obsidian",
      "required": false
    }
  ]
}
EvanHsieh0415 commented 1 year ago

also what mod as c:obsidian

Perhaps rare, but there are no Forge tags available for use in Fabric.

UnRealDinnerbone commented 1 year ago

I I will at fixing this just going to change it a bit

EvanHsieh0415 commented 1 year ago

also what mod as c:obsidian

I found it, the full name of c tag is convention tags, which is the tag implemented by fabric. FabricMC/fabric/fabric-convention-tags-v1

UnRealDinnerbone commented 1 year ago

Yha I noticed that where it came from. I just removed the tag usage