search

nank1ro / flutter-shadcn-ui

shadcn-ui ported in Flutter. Awesome UI components for Flutter, fully customizable.
https://mariuti.com/shadcn-ui
MIT License
657 stars 42 forks source link

feat/progress #39

Closed eb-so closed 3 months ago

eb-so commented 3 months ago

Hey @nank1ro I almost made it work but I'm stuck getting the bar width to reflect the correct value If you have an idea how to fix this issue please let me know and also do a review to see if the code looks good

nank1ro commented 3 months ago

Hi @eb-so thanks for the PR. I tried it but I found out that rewriting from scratch was not needed. I opened another PR while I was testing and just wrapping the LinearProgressIndicator with a ClipRRect was enough to satisfy the requirements of the shadcn_ui component.

Closing in favor of this other PR

eb-so commented 3 months ago

@nank1ro I was trying to get the animation right, I thought we should adhere to the original spec but this works too 😄

nank1ro commented 3 months ago

Sorry @eb-so I completely forgot the animation. Didn't saw it in the shadcn source code and just noticed it now in the radix ui source code 😅 We may reuse your code as a starting point, and add it.