search

nank1ro / flutter-shadcn-ui

shadcn-ui ported in Flutter. Awesome UI components for Flutter, fully customizable.
https://mariuti.com/shadcn-ui
MIT License
657 stars 42 forks source link

fix/input-on-tap #72

Closed nank1ro closed 4 weeks ago

nank1ro commented 1 month ago

closes #71

Anas35 commented 1 month ago

Thanks for quick fix. I can confirm that onTap is working now. There is some exception that is thrown when starting to type. 

The following assertion was thrown while dispatching notifications for _HighlightModeManager:
Looking up a deactivated widget's ancestor is unsafe.
At this point the state of the widget's element tree is no longer stable.
To safely refer to a widget's ancestor in its dispose() method, save a reference to the ancestor by calling dependOnInheritedWidgetOfExactType() in the widget's didChangeDependencies() method.

When the exception was thrown, this was the stack:
#0      Element._debugCheckStateIsActiveForAncestorLookup.<anonymous closure> (package:flutter/src/widgets/framework.dart:4743:9)
framework.dart:4743
#1      Element._debugCheckStateIsActiveForAncestorLookup (package:flutter/src/widgets/framework.dart:4757:6)
framework.dart:4757
#2      Element.getElementForInheritedWidgetOfExactType (package:flutter/src/widgets/framework.dart:4792:12)
framework.dart:4792
#3      InheritedModel._findModels (package:flutter/src/widgets/inherited_model.dart:143:45)
inherited_model.dart:143
#4      InheritedModel.inheritFrom (package:flutter/src/widgets/inherited_model.dart:191:5)
inherited_model.dart:191
#5      MediaQuery._maybeOf (package:flutter/src/widgets/media_query.dart:1212:27)
media_query.dart:1212
#6      MediaQuery.maybeNavigationModeOf (package:flutter/src/widgets/media_query.dart:1592:73)
media_query.dart:1592
#7      _InkResponseState._shouldShowFocus (package:flutter/src/material/ink_well.dart:1091:31)
ink_well.dart:1091
#8      _InkResponseState.updateFocusHighlights (package:flutter/src/material/ink_well.dart:1100:41)
ink_well.dart:1100
#9      _InkResponseState.handleFocusHighlightModeChange.<anonymous closure> (package:flutter/src/material/ink_well.dart:1086:7)
ink_well.dart:1086
#10     State.setState (package:flutter/src/widgets/framework.dart:1203:30)
framework.dart:1203
#11     _InkResponseState.handleFocusHighlightModeChange (package:flutter/src/material/ink_well.dart:1085:5)
#12     _HighlightModeManager.notifyListeners (package:flutter/src/widgets/focus_manager.dart:1978:19)
focus_manager.dart:1978
#13     _HighlightModeManager.updateMode (package:flutter/src/widgets/focus_manager.dart:2154:7)
focus_manager.dart:2154
#14     _HighlightModeManager.handleKeyMessage (package:flutter/src/widgets/focus_manager.dart:2026:5)
focus_manager.dart:2026
#15     KeyEventManager._dispatchKeyMessage (package:flutter/src/services/hardware_keyboard.dart:1100:34)
hardware_keyboard.dart:1100
#16     KeyEventManager.handleRawKeyMessage (package:flutter/src/services/hardware_keyboard.dart:1172:17)
hardware_keyboard.dart:1172
#17     BasicMessageChannel.setMessageHandler.<anonymous closure> (package:flutter/src/services/platform_channel.dart:235:49)
platform_channel.dart:235
#18     _DefaultBinaryMessenger.setMessageHandler.<anonymous closure> (package:flutter/src/services/binding.dart:581:35)
binding.dart:581
#19     _invoke2 (dart:ui/hooks.dart:344:13)
hooks.dart:344
#20     _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:45:5)
channel_buffers.dart:45
#21     _Channel.push (dart:ui/channel_buffers.dart:135:31)
channel_buffers.dart:135
#22     ChannelBuffers.push (dart:ui/channel_buffers.dart:343:17)
channel_buffers.dart:343
#23     PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:750:22)
platform_dispatcher.dart:750
#24     _dispatchPlatformMessage (dart:ui/hooks.dart:257:31)
hooks.dart:257

The _HighlightModeManager sending notification was: Instance of '_HighlightModeManager'
nank1ro commented 1 month ago

In which platform are you running?

Anas35 commented 1 month ago

All good! I can no longer reproduce it, maybe it got caught up with pretty bad state. Sorry for any inconvenience & thanks for quick fix for onTap.