nank1ro / solidart

Signals in Dart and Flutter, inspired by SolidJS
https://docs.page/nank1ro/solidart
MIT License
155 stars 5 forks source link

[bugfix] uncancelled stream subscription on resource #64

Closed nank1ro closed 11 months ago

nank1ro commented 11 months ago

When the stream being passed to a Resource was not broadcast, the subscription was not properly cancelled

codecov[bot] commented 11 months ago

Codecov Report

Merging #64 (07bae7e) into main (f5c2bfc) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/nank1ro/solidart/pull/64/graphs/tree.svg?width=650&height=150&src=pr&token=HvJYtaixiW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti)](https://app.codecov.io/gh/nank1ro/solidart/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti) ```diff @@ Coverage Diff @@ ## main #64 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 17 17 Lines 756 769 +13 ========================================= + Hits 756 769 +13 ``` | [Files](https://app.codecov.io/gh/nank1ro/solidart/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti) | Coverage Δ | | |---|---|---| | [packages/solidart/lib/src/core/resource.dart](https://app.codecov.io/gh/nank1ro/solidart/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti#diff-cGFja2FnZXMvc29saWRhcnQvbGliL3NyYy9jb3JlL3Jlc291cmNlLmRhcnQ=) | `100.00% <100.00%> (ø)` | |