search

nank1ro / solidart

Signals in Dart and Flutter, inspired by SolidJS
https://docs.page/nank1ro/solidart
MIT License
155 stars 5 forks source link

Bugfix update value should not notify listeners #73

Closed 9dan closed 10 months ago

9dan commented 10 months ago

Fixes a bug that cause an update of the value to notify the observers of the signal

codecov[bot] commented 10 months ago

Codecov Report

Merging #73 (778b0bf) into main (f75f842) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/nank1ro/solidart/pull/73/graphs/tree.svg?width=650&height=150&src=pr&token=HvJYtaixiW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti)](https://app.codecov.io/gh/nank1ro/solidart/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti) ```diff @@ Coverage Diff @@ ## main #73 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 1178 1178 ========================================= Hits 1178 1178 ``` | [Files](https://app.codecov.io/gh/nank1ro/solidart/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti) | Coverage Δ | | |---|---|---| | [...ackages/flutter\_solidart/lib/src/widgets/show.dart](https://app.codecov.io/gh/nank1ro/solidart/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti#diff-cGFja2FnZXMvZmx1dHRlcl9zb2xpZGFydC9saWIvc3JjL3dpZGdldHMvc2hvdy5kYXJ0) | `100.00% <ø> (ø)` | | | [...utter\_solidart/lib/src/widgets/signal\_builder.dart](https://app.codecov.io/gh/nank1ro/solidart/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti#diff-cGFja2FnZXMvZmx1dHRlcl9zb2xpZGFydC9saWIvc3JjL3dpZGdldHMvc2lnbmFsX2J1aWxkZXIuZGFydA==) | `100.00% <ø> (ø)` | | | [...ckages/flutter\_solidart/lib/src/widgets/solid.dart](https://app.codecov.io/gh/nank1ro/solidart/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti#diff-cGFja2FnZXMvZmx1dHRlcl9zb2xpZGFydC9saWIvc3JjL3dpZGdldHMvc29saWQuZGFydA==) | `100.00% <ø> (ø)` | | | [packages/solidart/lib/src/core/signal.dart](https://app.codecov.io/gh/nank1ro/solidart/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alexandru+Mariuti#diff-cGFja2FnZXMvc29saWRhcnQvbGliL3NyYy9jb3JlL3NpZ25hbC5kYXJ0) | `100.00% <100.00%> (ø)` | |
nank1ro commented 10 months ago

@all-contributors please add @9dan for code, bug, doc

allcontributors[bot] commented 10 months ago

@nank1ro

I've put up a pull request to add @9dan! :tada: