nanmu42 / etherscan-api

:guitar: Golang client for Ethereum Etherscan API (and its families like BscScan) / Golang 以太坊 Etherscan API库(也支持同一家族的BscScan)
MIT License
240 stars 107 forks source link

Repair nil check of compose() #4

Closed nanmu42 closed 6 years ago

nanmu42 commented 6 years ago

An interface is nil only when both its type and value are nil. Detail: https://golang.org/doc/faq#nil_error

A big thank you to llya Evdokimov (@engenegr) for finding this bug (#3) ! ;)

codecov[bot] commented 6 years ago

Codecov Report

Merging #4 into master will decrease coverage by 0.1%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   78.43%   78.32%   -0.11%     
==========================================
  Files          10       10              
  Lines         255      263       +8     
==========================================
+ Hits          200      206       +6     
- Misses         33       34       +1     
- Partials       22       23       +1
Impacted Files Coverage Δ
reflect.go 91.3% <0%> (ø) :arrow_up:
helper.go 78.12% <100%> (+4.05%) :arrow_up:
client.go 51.35% <33.33%> (-0.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19383e3...06e346a. Read the comment docs.