nano-wallet-company / nano-wallet-desktop

An ambitious Nano wallet for desktop and web.
https://nanowalletcompany.com
BSD 2-Clause "Simplified" License
36 stars 24 forks source link

Deleting accounts #24

Closed ghost closed 4 years ago

ghost commented 6 years ago

Why isn't this a feature?

devinus commented 6 years ago

The code for this actually already exists, the problem is going to be handling it gracefully. Since you cannot actually delete an account but merely hide it, how do we want to handle it?

See: https://github.com/nano-wallet-company/nano-wallet-desktop/blob/a76a18bdce06303f4c56913138a8e941437c832f/app/components/account-settings/component.js#L26

ghost commented 6 years ago

Thanks

I think archive is going to be the only realistic solution there.

ghost commented 6 years ago

I've been reflecting more, and something that seems to be common with banking apps is having hidden accounts.

I personally, with my banking app, have only my spending account easily visible, then have to go deeper to find my other accounts.

So I'm suggesting:

3 states for accounts

  1. Normal
  2. Hidden
  3. Archived

The current "overview" / home page would show all the normal accounts in the carousel, then have a new page, Accounts, which will show the accounts listed by state Normal, Hidden, Archived, then name.

Also, maybe accounts can only be archived IF they have a zero balance? That would make sense, and then if they received payment it could bump their state back to visible, or announce it to the end user

It would also mean potentially modifying the individual account overview page + other implications.

zhyatt commented 4 years ago

The NanoWalletCompany is no longer supporting this app. See https://nanowalletcompany.com/ for details. Closing.