Closed adrianm3 closed 3 years ago
Author(s) | Adrian Manjarrez |
Status | Closed |
Phase | 1 |
Open Date | 11-19-2020 |
Close Date | 12-03-2020 |
Are there any more folks we can add as reviews or contributors before opening the review period?
test comment for slack
Are there any more folks we can add as reviews or contributors before opening the review period?
Other reviewers could be Lili, Sam, and Aagam. I'm not sure how to tell who (or if) anyone has been formally assigned yet.
@elifleaf @adrianm3 @greghbauer @AagamShah97 @tawfick The review RFC period for this project is now open, refer to the phase 1 review guide here: https://github.com/nanoMFG/community/blob/master/governance/planning-review.md for phase 1 review criterial. Also, take advantage of the line comment capabilities. The document to be reviewed can most easily be access by visiting the "Files Changed" tab above. I pinged Lili Cai on slack to setup a github account so she can be added as a reviewer.
@elifleaf @tawfick @AagamShah97 @greghbauer: REMINDER: In order to complete this phase 1 review the closing date (12/3). Please offer your feedback ASAP. If there are particular features or requirements you would like to suggest, this a good time. The formal rubric I used above is a good guide, but need not be used in its entirety by all reviewers. Please feel free to offer your advice and suggestions on any or all particular areas during this RFC period. You can find the phase 1 review guide here: https://github.com/nanoMFG/community/blob/master/governance/planning-review.md Thanks!
@adrianm3 Are you able to address the recommendations above to finish phase 1 and close this pr? @nanoMFG/nanodiam-dev Please add comments here, line comments in the "Files changed" tab or commit your own SPD updates to @adrianm3 's branch to help address the RFC recommendations and move on to phase 2. Thanks!