search

nanobox-io / nanobox-engine-php

Engine for running PHP apps on Nanobox
https://nanobox.io
MIT License
19 stars 15 forks source link

php.ini set to log on a file not being watched #74

Closed fariasf closed 6 years ago

fariasf commented 6 years ago

The default php.ini is set to log on /data/var/log/php/error.log (https://github.com/nanobox-io/nanobox-engine-php/blob/master/templates/php/php.ini.mustache#L36).

But php-server, and I think the default log_watch value for prod (not sure if that's the right file) watch for a different path: /data/var/log/php/php_error.log.

As a result, the default behavior ignores the PHP error logs (they are stored, but not displayed to the user unless adding a custom log_watch entry to the boxfile for production and starting the servers with a custom command for local development).

notxarb commented 6 years ago

This should be fixed now

fariasf commented 6 years ago

Thanks! Indeed, PR #76 fixes it. LGTM!