nanobox-io / nanobox-engine-python

Engine for running Python apps on Nanobox
https://nanobox.io
MIT License
12 stars 13 forks source link

Python engine cmd error #44

Closed denhartog closed 5 years ago

denhartog commented 6 years ago

"FAILED TO CLONING" should be singular "CLONE"

ON failure: nanobox run

danhunsaker commented 6 years ago

What is the engine set to in your boxfile.yml?

denhartog commented 6 years ago

engine: pythong; which of course is invalid. I thought it was curious nanobox even tried to proceed with a non-existent engine. Regardless, "cloning" should be "clone" and is a nanobox thing rather than a particular engine.

sanderson commented 6 years ago

@denhartog Engines can be pulled from anywhere, not just from the Nanobox engine repos. However, if a single-word engine name is provided, it assumes nanobox-io/nanobox-engine-<name> on github. But you can also use a local engine:

run.config:
  engine: ../some-local-dir

or a custom engine on github:

run.config:
  engine: ghuser/custom-repo

In regards to the wording of the error message, FAILED TO is generic text for all messages CLONING ... is the step that failed. So while the verbiage of the error message sounds incorrect, the context may explain why.

denhartog commented 6 years ago

All the same; thanks for the explanation. Excited to explore nanobox.io more!