nanoc / features

Collection of feature requests
2 stars 1 forks source link

Improve flexibility of Atom feed generator in blogging helper #30

Closed denisdefreyne closed 6 years ago

denisdefreyne commented 6 years ago

Migrated from nanoc/nanoc#1300.

@iay said:

The current Atom feed generator uses a single item from the configuration file (@config[:base_url]) for three different, logically separate functions:

Only the first of these uses, which specifies the base from which links within content should be interpreted as relative to, can legitimately be regarded as a per-site configuration:

This is one where (because I have two blogs on my site, and they are both subsites) my need for this is fairly sharp, and the code looks simple enough that I might be able to propose a PR if you don't think you would have the time to look into it. Let me know if that's the case.


Another note on this: the W3C validator flags a link like <link rel="alternate" href="https://iay.org.uk/"/> with a compatibility recommendation that it should be a same-document reference (see this).

I think that means that the existing implementation would be improved if it just used / here, but perhaps that's a separate issue. Certainly, any new parameter should not be appended to base URL by this reading.

iay commented 6 years ago

Proposed fix is nanoc/nanoc#1301.

denisdefreyne commented 6 years ago

@iay With nanoc/nanoc#1301 merged, can this be closed now?

iay commented 6 years ago

Yes, I think so.