Closed moll closed 5 years ago
While on the topic, why did you go with
env_name
as opposed toenv
, which would better matchNANOC_ENV
,Rails.env
and the likes?
When I think of “the environment”, I think of the the environment and its contents, rather than its name. Configuration#env_name
clearly returns the name of the environment, but what would Configuration#env
return? Some might argue that it should return the name, while others might argue that it returns the contents (a Ruby Hash
) instance. For this reason, I prefer to be explicit.
ACK and thanks for the record here, too!
Hey,
This is an issue for me/us to not forget to add
env_name
toConfigView
to match the method inConfiguration
. It'd be for getting the environment in theRules
file.While on the topic, why did you go with
env_name
as opposed toenv
, which would better matchNANOC_ENV
,Rails.env
and the likes?Cheers