nanocurrency / nano-docs

Documentation for the Nano protocol
https://docs.nano.org/
153 stars 121 forks source link

Development docker image no longer working #592

Closed koczadly closed 2 years ago

koczadly commented 3 years ago

Not too familiar with Docker (so I may be doing something wrong), but it seems the suggested nanocurrency/nano-docs docker image for testing no longer works.

docker run ... gives the following output:

MkDocs encountered as error parsing the configuration file: could not determine a constructor for the tag '!ENV'
  in "/docs/mkdocs.yml", line 175, column 16

Even if I change the !ENV line to TRUE, MkDocs then complains about missing plugins.

zhyatt commented 2 years ago

@koczadly I believe this is no longer an issue. Can you confirm?

koczadly commented 2 years ago

@zhyatt still getting issues, not sure if I'm just being dumb and missing a step.

karl@KARL-DESKTOP:/mnt/c/Users/Karl/Documents/Projects/Programming/Nano/nano-docs$ docker pull nanocurrency/nano-docs:base
base: Pulling from nanocurrency/nano-docs
Digest: sha256:19d6626f99c3bc751f101c84590a894e2bfb6e46b11d24e53e9b7eb69df45015
Status: Image is up to date for nanocurrency/nano-docs:base
docker.io/nanocurrency/nano-docs:base

karl@KARL-DESKTOP:/mnt/c/Users/Karl/Documents/Projects/Programming/Nano/nano-docs$ docker run --rm -it -p 8000:8000 -v ${PWD}:/docs nanocurrency/nano-docs:base
INFO    -  Building documentation...

MkDocs encountered as error parsing the configuration file: could not determine a constructor for the tag '!ENV'
  in "/docs/mkdocs.yml", line 186, column 16
zhyatt commented 2 years ago

@koczadly Ah, I see. We no longer use the Docker hub but instead the github registry. See the setup here: https://github.com/nanocurrency/nano-docs/pkgs/container/nano-docs for more details. Containers are generated and pushed there with each PR and a latest tag is available as well. I will look into cleaning up the Docker hub.

koczadly commented 2 years ago

Gotcha! You might wanna change the repo readme then - I was following the guidance from there.

zhyatt commented 2 years ago

Oh man, thanks @koczadly. The lower part of the Docker instructions were correct but not the main top part. Updated in a4603266ecf209a7fe0cef522780a2ec19a650ba!