nanocurrency / nano-node

Nano is digital currency. Its ticker is: XNO and its currency symbol is: Ӿ
https://nano.org
BSD 3-Clause "New" or "Revised" License
3.48k stars 786 forks source link

Display "new version is available" #1178

Open Sovxx opened 5 years ago

Sovxx commented 5 years ago

nano_wallet v16

I can see quite a lot of peers use a rather old node version.

Suggestion: when 20% of the peers have a node version newer than yours, show it on the home window. Like

Version 13.0 (newer version is available)

(with a link to nano website ?) instead of

Version 13.0

elliottminns commented 5 years ago

It seems this is currently only possible comparing with the protocol version rather than the client version as only the agent's protocol version is exchanged during the handshake. In order for this to work with the client version, more user agent information would need to be exchanged.

cryptocode commented 5 years ago

@elliottminns You're right, here's the relevant issue: https://github.com/nanocurrency/raiblocks/issues/1120

lucaslopes commented 5 years ago

Suggestion: when 20% of the peers have a node version newer than yours, show it on the home window.

Why a certain percentage instead of when a new version is released?

Sovxx commented 5 years ago

To make it decentralized, independent from a server. Just my 2 cents.

zhyatt commented 4 years ago

This will become easier after #2225 is complete.