search

nanocurrency / nano-node

Nano is digital currency. Its ticker is: XNO and its currency symbol is: Ӿ
https://nano.org
BSD 3-Clause "New" or "Revised" License
3.48k stars 786 forks source link

In github CI, the results of RPC, QT and load tests are not checked #3346

Open dsiganos opened 3 years ago

dsiganos commented 3 years ago

Summary

In github CI, the results of RPC, QT and load tests are not checked.

Node version

V22.1

Build details

manual

OS and version

any

Steps to reproduce the behavior

Check github ci builds. You will see that the load test has been failing for a long time but the result dos not affect the overall outcome.

Expected behavior

CI test should fail

Actual behavior

CI test does not fail

Possible solution

Fix the script ci/test.sh

Supporting files

No response

zhyatt commented 2 years ago

load_test was removed here: https://github.com/nanocurrency/nano-node/pull/3373, but rpc_test and qt_test should be required in this release

clemahieu commented 2 years ago

As a first step we should qualify what, if any, tests make the CI build fail.