search

nanocurrency / nano-node

Nano is digital currency. Its ticker is: XNO and its currency symbol is: Ӿ
https://nano.org
BSD 3-Clause "New" or "Revised" License
3.48k stars 786 forks source link

nanoapi_generated.h should be generated in the build folder #3498

Open dsiganos opened 2 years ago

dsiganos commented 2 years ago

After the upgrade of flatbuffers library my build broke and even deleting the entire build directory didn't fix the problem. I think the problem was that nanoapi_generated.h needed refreshing. The build started succeeding after I deleted nanoapi_generated.h and I rebuilt everything. That makes me wonder, shouldn't nanoapi_generated.h be residing in the build directory?

I am not sure what the problem was exactly, all I know is that my build started succeeding when I deleted it. And my question is, since it is a build artifact, shouldn't it be in the build directory?

dsiganos commented 2 years ago

Relevant discussion on slack: https://nanocurrency.slack.com/archives/C0220JV075L/p1633703163306400

dsiganos commented 2 years ago

@cryptocode , do you have any input on this?

cryptocode commented 2 years ago

@dsiganos Yeah, emitting it to the build dir sounds better. I don't recall if there was a reason for doing it the current way or not.