Protocol 19, bulk_pull ascending, remove vote_by_block

nanocurrency / protocol

Implementation independent content related to the Nano protocol

BSD 2-Clause "Simplified" License

36 stars 10 forks source link

Protocol 19, bulk_pull ascending, remove vote_by_block #30

Closed dsiganos closed 2 years ago

dsiganos commented 2 years ago

Add support for bulk_pull_ascending_flag
Protocol v19
Add makefile for generating the diagram.
Drop support for confirm_ack with block payload (vote by block)

dsiganos commented 2 years ago

@cryptocode , it would be great if you could do a quick review since you know Kaitai best. Thanks.

cryptocode commented 2 years ago

@cryptocode , it would be great if you could do a quick review since you know Kaitai best. Thanks.

Looks good, maybe just update the msg_confirm_ack doc to reflect that it's only vote-by-hash now.

dsiganos commented 2 years ago

@cryptocode , it would be great if you could do a quick review since you know Kaitai best. Thanks.

Looks good, maybe just update the msg_confirm_ack doc to reflect that it's only vote-by-hash now.

Done. Thank you.