Closed cryptocode closed 3 years ago
telemetry_req No payload
telemetry_ack
header.extensions
contains the size of the telemetry data payload.
64 block_count
64 cemented_count
64 unchecked_count
64 account_count
64 bandwidth_cap
64 uptime
32 peer_count
8 protocol_version
256 genesis_block
8 major_version
8 minor_version
8 patch_version
8 pre_release_version
8 maker
64 timestamp
I think it should specify the type, not jus the size.
For comparation:
I think blockcount
, for instance, is an uint64le, but it's not specified. I think it should be like the vote_common
, with type: u8le
.
@Inkeliz
Makes sense, thanks. https://github.com/nanocurrency/protocol/pull/12/files. In case it affects any testing, we have also modified the data so be consistent, it is all big endian now.
Fixed in #12
https://github.com/nanocurrency/nano-node/pull/2446