fix(@nanoexpress/middleware-schemator): Fix import config file in Windows

nanoexpress / middlewares

Middleware packages for nanoexpress

20 stars 10 forks source link

fix(@nanoexpress/middleware-schemator): Fix import config file in Windows #22

Closed HasanHaghniya closed 3 years ago

HasanHaghniya commented 3 years ago

Pull Request

Is you/your team sponsoring this project

[ ] Yes
[x] No

If your team sponsoring this project, please attach here your team lead or who purchased license GitHub login

What you changed

[x] Code changes
[ ] Tests changed
[ ] Typo fixes

If you change code, tests should be passed

Note

Your every change to feature/code should be documented
📝 Documentation fixes should be filled here
nanoexpress fixes should be filled here

dalisoft commented 3 years ago

Please fix commit style

dalisoft commented 3 years ago

No, it’s wrong. Please update commit message. Commit message should be like this https://github.com/nanoexpress/middlewares/commit/99813a0754fd458630e4ee71a1e0df8974266c15

HasanHaghniya commented 3 years ago

is that cool?

dalisoft commented 3 years ago

Commit message also should be same as title

dalisoft commented 3 years ago

@Team-OF Re-create PR with commit message fix(@nanoexpress/middleware-schemator): Fix import config file in Windows, there are few steps for example

# you edit files
git add -A packages/schemator
git commit -m "fix(@nanoexpress/middleware-schemator): Fix import config file in Windows"
git push

torbjorn-kvist commented 3 years ago

This "fix" breaks on debian (linux), as this removes the first '/' in the path using the substring(1) Error: ENOENT: no such file or directory, open 'home/user/code/backend/swagger.yml'

The path on debian should be /home/user/code/backend/swagger.yml If the fix is needed for windows, what kind of error did @SecretsNetwork get with the previous solution?